Hello Everyone,

I agree with Fabian and Alex. I second Fabian suggestion of adding the Ticket number to commit messages.

Kindly
Timon
_____________________________
Universität Bern
Vizerektorat Lehre
iLUB - Supportstelle für ICT-gestützte Lehre und Forschung

Technische Leitung iLUB
Konzeption und Entwicklung ILIAS

Hochschulstrasse 6
3012 Bern

<mailto:timon.amstutz@unibe.ch>
http://ilias.unibe.ch/u/t.amstutz

http://www.ilub.unibe.ch

Am 30.11.2023 um 07:59 schrieb Fabian Schmid <fabian@sr.solutions>:

Hello everyone

I support Alex's suggestion and also share his opinion: We should turn this around, a schema for the commit messages (in general), which includes the mantis number
for bugfixes. This can then be used to find the commits per issue, regardless of whether they are security or regular issues.

I've been trying to do it this way for some time now, it wouldn't be a change for me :-)

Freundliche Grüsse


Fabian Schmid

--
Fabian Schmid
Geschäftsführer
Leitung Softwareentwicklung

Support: +41 31 972 52 30
support@sr.solutions

sr solutions ag
Farbweg 9
3400 Burgdorf
Schweiz

Tel: +41 31 972 52 22
https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsr.solutions%2F&data=05%7C01%7Ctimon.amstutz%40unibe.ch%7C3a6490189dec4f29f0b208dbf172389d%7Cd400387a212f43eaac7f77aa12d7977e%7C1%7C0%7C638369245133748468%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WbNrYULjUvN%2BwJo0aYg692BcgKyGDFtdKX3EFMypSvQ%3D&reserved=0


Am 28.11.2023 um 17:24 schrieb Alexander Killing <killing@leifos.com>:

Hi Rob,

I understand the need to have this information available in the reports. However developers are a our scarce resource. We should make their workflows more efficient, not add additional workload.

I think it should be possible to automate this process. Developers should include the mantis report numbers into their commit messages using a predefined format. Some script should read the messages, extract the commit numbers and add them into a new custom field within the mantis reports as links.

Best
Alex


Am 28.11.23 um 12:00 schrieb Rob Falkenstein:
Dear ILIAS-Developers,

we recently decided within the security group that we want to better document all related commits that solve a mantis issue. That means either the developer or a person of the security group posts all commit URLs (for each branch) as a comment into the ticket before it is set to resolved. This helps us to better document fixes and helps everyone involved in keeping an overview over the related code changes.

Thus, we are preparing a PR in order to document this change. Considering this PR we would like to extend it by introducing this to all mantis bugs being solved. This would mean that the person that the issue is assigned to and who solves the issue will have to provide all URLs that solve this issue in the comments of the mantis ticket.
Please let me know if anybody considers this a bad idea and we will organize a workshop in order to tackle this problem. If you consider this a good idea you can let me know, too :-).
If there's no need for a workshop I'll provide the PR probably in January.

Best regards,
Rob


_______________________________________________
developers mailing list -- developers@lists.ilias.de
To unsubscribe send an email to developers-leave@lists.ilias.de
_______________________________________________
developers mailing list -- developers@lists.ilias.de
To unsubscribe send an email to developers-leave@lists.ilias.de


_______________________________________________
developers mailing list -- developers@lists.ilias.de
To unsubscribe send an email to developers-leave@lists.ilias.de