Dear ILIAS-Developers,
we recently decided within the security group that we want to better document all related commits that solve a mantis issue. That means either the developer or a person of the security group posts all commit URLs (for each branch) as a comment into the ticket before it is set to resolved. This helps us to better document fixes and helps everyone involved in keeping an overview over the related code changes.
Thus, we are preparing a PR in order to document this change. Considering this PR we would like to extend it by introducing this to all mantis bugs being solved. This would mean that the person that the issue is assigned to and who solves the issue will have to provide all URLs that solve this issue in the comments of the mantis ticket. Please let me know if anybody considers this a bad idea and we will organize a workshop in order to tackle this problem. If you consider this a good idea you can let me know, too :-). If there's no need for a workshop I'll provide the PR probably in January.
Best regards, Rob
Hi Rob,
I understand the need to have this information available in the reports. However developers are a our scarce resource. We should make their workflows more efficient, not add additional workload.
I think it should be possible to automate this process. Developers should include the mantis report numbers into their commit messages using a predefined format. Some script should read the messages, extract the commit numbers and add them into a new custom field within the mantis reports as links.
Best Alex
Am 28.11.23 um 12:00 schrieb Rob Falkenstein:
Dear ILIAS-Developers,
we recently decided within the security group that we want to better document all related commits that solve a mantis issue. That means either the developer or a person of the security group posts all commit URLs (for each branch) as a comment into the ticket before it is set to resolved. This helps us to better document fixes and helps everyone involved in keeping an overview over the related code changes.
Thus, we are preparing a PR in order to document this change. Considering this PR we would like to extend it by introducing this to all mantis bugs being solved. This would mean that the person that the issue is assigned to and who solves the issue will have to provide all URLs that solve this issue in the comments of the mantis ticket. Please let me know if anybody considers this a bad idea and we will organize a workshop in order to tackle this problem. If you consider this a good idea you can let me know, too :-). If there's no need for a workshop I'll provide the PR probably in January.
Best regards, Rob
developers mailing list -- developers@lists.ilias.de To unsubscribe send an email to developers-leave@lists.ilias.de
Hello everyone
I support Alex's suggestion and also share his opinion: We should turn this around, a schema for the commit messages (in general), which includes the mantis number for bugfixes. This can then be used to find the commits per issue, regardless of whether they are security or regular issues.
I've been trying to do it this way for some time now, it wouldn't be a change for me :-)
Freundliche Grüsse
Fabian Schmid
-- Fabian Schmid Geschäftsführer Leitung Softwareentwicklung
Support: +41 31 972 52 30 support@sr.solutions
sr solutions ag Farbweg 9 3400 Burgdorf Schweiz
Tel: +41 31 972 52 22 https://sr.solutions/
Am 28.11.2023 um 17:24 schrieb Alexander Killing killing@leifos.com:
Hi Rob,
I understand the need to have this information available in the reports. However developers are a our scarce resource. We should make their workflows more efficient, not add additional workload.
I think it should be possible to automate this process. Developers should include the mantis report numbers into their commit messages using a predefined format. Some script should read the messages, extract the commit numbers and add them into a new custom field within the mantis reports as links.
Best Alex
Am 28.11.23 um 12:00 schrieb Rob Falkenstein:
Dear ILIAS-Developers,
we recently decided within the security group that we want to better document all related commits that solve a mantis issue. That means either the developer or a person of the security group posts all commit URLs (for each branch) as a comment into the ticket before it is set to resolved. This helps us to better document fixes and helps everyone involved in keeping an overview over the related code changes.
Thus, we are preparing a PR in order to document this change. Considering this PR we would like to extend it by introducing this to all mantis bugs being solved. This would mean that the person that the issue is assigned to and who solves the issue will have to provide all URLs that solve this issue in the comments of the mantis ticket. Please let me know if anybody considers this a bad idea and we will organize a workshop in order to tackle this problem. If you consider this a good idea you can let me know, too :-). If there's no need for a workshop I'll provide the PR probably in January.
Best regards, Rob
developers mailing list -- developers@lists.ilias.de To unsubscribe send an email to developers-leave@lists.ilias.de
developers mailing list -- developers@lists.ilias.de To unsubscribe send an email to developers-leave@lists.ilias.de
Hello Everyone,
I agree with Fabian and Alex. I second Fabian suggestion of adding the Ticket number to commit messages.
Kindly Timon _____________________________ Universität Bern Vizerektorat Lehre iLUB - Supportstelle für ICT-gestützte Lehre und Forschung
Technische Leitung iLUB Konzeption und Entwicklung ILIAS
Hochschulstrasse 6 3012 Bern
mailto:timon.amstutz@unibe.ch http://ilias.unibe.ch/u/t.amstutz
Am 30.11.2023 um 07:59 schrieb Fabian Schmid <fabian@sr.solutionsmailto:fabian@sr.solutions>:
Hello everyone
I support Alex's suggestion and also share his opinion: We should turn this around, a schema for the commit messages (in general), which includes the mantis number for bugfixes. This can then be used to find the commits per issue, regardless of whether they are security or regular issues.
I've been trying to do it this way for some time now, it wouldn't be a change for me :-)
Freundliche Grüsse
Fabian Schmid
-- Fabian Schmid Geschäftsführer Leitung Softwareentwicklung
Support: +41 31 972 52 30 support@sr.solutionsmailto:support@sr.solutions
sr solutions ag Farbweg 9 3400 Burgdorf Schweiz
Tel: +41 31 972 52 22 https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsr.solutio...
Am 28.11.2023 um 17:24 schrieb Alexander Killing killing@leifos.com:
Hi Rob,
I understand the need to have this information available in the reports. However developers are a our scarce resource. We should make their workflows more efficient, not add additional workload.
I think it should be possible to automate this process. Developers should include the mantis report numbers into their commit messages using a predefined format. Some script should read the messages, extract the commit numbers and add them into a new custom field within the mantis reports as links.
Best Alex
Am 28.11.23 um 12:00 schrieb Rob Falkenstein: Dear ILIAS-Developers,
we recently decided within the security group that we want to better document all related commits that solve a mantis issue. That means either the developer or a person of the security group posts all commit URLs (for each branch) as a comment into the ticket before it is set to resolved. This helps us to better document fixes and helps everyone involved in keeping an overview over the related code changes.
Thus, we are preparing a PR in order to document this change. Considering this PR we would like to extend it by introducing this to all mantis bugs being solved. This would mean that the person that the issue is assigned to and who solves the issue will have to provide all URLs that solve this issue in the comments of the mantis ticket. Please let me know if anybody considers this a bad idea and we will organize a workshop in order to tackle this problem. If you consider this a good idea you can let me know, too :-). If there's no need for a workshop I'll provide the PR probably in January.
Best regards, Rob
_______________________________________________ developers mailing list -- developers@lists.ilias.de To unsubscribe send an email to developers-leave@lists.ilias.de _______________________________________________ developers mailing list -- developers@lists.ilias.de To unsubscribe send an email to developers-leave@lists.ilias.de
_______________________________________________ developers mailing list -- developers@lists.ilias.de To unsubscribe send an email to developers-leave@lists.ilias.de
Hi,
as far as im in favor of the improvement to make the bugfixing process more transparent to external watchers i would propose the small change to that concept not to persist the solving commits, but the PRs themself.
This way the developer has more options to add further information to the technical side of a fix if he want, but isnt obliged to. Also this grant more flexibility within resolving of a Bug since noone is forced to squash a full resolvment into one commit or to update her/his "commit list" evrytime it changes. Also, due to the features of Github, PR can be linked and organized more easly there than in mantis wich would reduce the workload for the developers. And since PRs are already softly obliged to refer to their mantis ticket this would mean very less to no additional effort for the developer.
Greetings,
Ingmar Szmais
Am 30.11.23 um 07:59 schrieb Fabian Schmid:
Hello everyone
I support Alex's suggestion and also share his opinion: We should turn this around, a schema for the commit messages (in general), which includes the mantis number for bugfixes. This can then be used to find the commits per issue, regardless of whether they are security or regular issues.
I've been trying to do it this way for some time now, it wouldn't be a change for me :-)
Freundliche Grüsse
Fabian Schmid
-- Fabian Schmid Geschäftsführer Leitung Softwareentwicklung
Support: +41 31 972 52 30 support@sr.solutions
sr solutions ag Farbweg 9 3400 Burgdorf Schweiz
Tel: +41 31 972 52 22 https://sr.solutions/
Am 28.11.2023 um 17:24 schrieb Alexander Killingkilling@leifos.com:
Hi Rob,
I understand the need to have this information available in the reports. However developers are a our scarce resource. We should make their workflows more efficient, not add additional workload.
I think it should be possible to automate this process. Developers should include the mantis report numbers into their commit messages using a predefined format. Some script should read the messages, extract the commit numbers and add them into a new custom field within the mantis reports as links.
Best Alex
Am 28.11.23 um 12:00 schrieb Rob Falkenstein:
Dear ILIAS-Developers,
we recently decided within the security group that we want to better document all related commits that solve a mantis issue. That means either the developer or a person of the security group posts all commit URLs (for each branch) as a comment into the ticket before it is set to resolved. This helps us to better document fixes and helps everyone involved in keeping an overview over the related code changes.
Thus, we are preparing a PR in order to document this change. Considering this PR we would like to extend it by introducing this to all mantis bugs being solved. This would mean that the person that the issue is assigned to and who solves the issue will have to provide all URLs that solve this issue in the comments of the mantis ticket. Please let me know if anybody considers this a bad idea and we will organize a workshop in order to tackle this problem. If you consider this a good idea you can let me know, too :-). If there's no need for a workshop I'll provide the PR probably in January.
Best regards, Rob
developers mailing list --developers@lists.ilias.de To unsubscribe send an email todevelopers-leave@lists.ilias.de
developers mailing list --developers@lists.ilias.de To unsubscribe send an email todevelopers-leave@lists.ilias.de
developers mailing list --developers@lists.ilias.de To unsubscribe send an email todevelopers-leave@lists.ilias.de
-
Alexander Killing -
Fabian Schmid -
Ingmar Szmais -
Rob Falkenstein -
timon.amstutz＠unibe.ch